Closed noelmcloughlin closed 4 years ago
This PR fixes a major bug.
Bug
open-iscsi
open-iscsi.tmpl
+discovery.sendtargets.iscsi.MaxRecvDataSegmentLength = '32768'node.conn[0].iscsi.MaxRecvDataSegmentLength = '262144'node.conn[0].iscsi.MaxXmitDataSegmentLength = '0'node.conn[0].timeo.login_timeout = '15'node.conn[0].timeo.logout_timeout = '15'node.conn[0].timeo.noop_out_interval = '5'node.conn[0].timeo.noop_out_timeout = '5'node.leading_login = Nonode.session.cmds_max = '128'node.session.err_timeo.abort_timeout = '15'node.session.err_timeo.lu_reset_timeout = '30'node.session.err_timeo.tgt_reset_timeout = '30'node.session.initial_login_retry_max = '8'node.session.iscsi.FastAbort = Yesnode.session.iscsi.FirstBurstLength = '262144'node.session.iscsi.ImmediateData = Yesnode.session.iscsi.InitialR2T = Nonode.session.iscsi.MaxBurstLength = '16776192'node.session.nr_sessions = '1'node.session.queue_depth = '32'node.session.scan = autonode.session.timeo.replacement_timeout = '120'node.session.xmit_thread_priority = '-20'node.startup = manual
+discovery.sendtargets.iscsi.MaxRecvDataSegmentLength = "32768" +node.conn[0].iscsi.MaxRecvDataSegmentLength = "262144" +node.conn[0].iscsi.MaxXmitDataSegmentLength = "0" +node.conn[0].timeo.login_timeout = "15" ....... +node.session.xmit_thread_priority = "-20" node.startup = manual
Improvement If no "configuration" is defined in pillar data then do not create the configuration file. The default configuration file provided by the package is good enough.
@noelmcloughlin nice work !!!
:tada: This PR is included in version 1.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Thanks @aboe76 for the review.
This PR fixes a major bug.
Bug
open-iscsi
configuration was being corrupted byopen-iscsi.tmpl
jinja.Improvement If no "configuration" is defined in pillar data then do not create the configuration file. The default configuration file provided by the package is good enough.