fix(travis): fixes for Archlinux and CentOS

[noelmcloughlin]

PR progress checklist (to be filled in by reviewers)

• [x] Changes to documentation are appropriate (or tick if not required)
• [x] Changes to tests are appropriate (or tick if not required)
• [ ] Reviews completed

---

What type of PR is this?

Primary type

• [ ] [build] Changes related to the build system
• [ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
• [x] [ci] Changes to the continuous integration configuration
• [ ] [feat] A new feature
• [x] [fix] A bug fix
• [ ] [perf] A code change that improves performance
• [ ] [refactor] A code change that neither fixes a bug nor adds a feature
• [ ] [revert] A change used to revert a previous commit
• [ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

• [ ] [docs] Documentation changes
• [x] [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

• Fixes #34

Describe the changes you're proposing

Travis CI tests are failing for CentOS and Archlinux.

• CentOS cannot start target service as kernel boot is pending.
• Archlinux states had some weakness (fixed) and the python-configshell-fb package is broken.

33 and #34

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

• [ ] Updated the README (e.g. Available states).
• [ ] Updated pillar.example.

Testing checklist

• [ ] Included in Kitchen (i.e. under state_top).
• [ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
• [ ] Updated the relevant test pillar.

Additional context

[noelmcloughlin]

This PR has a workaround for https://bugs.archlinux.org/task/66317

[noelmcloughlin]

Travis passed but I'll restart to see if the following error is occurring now.

       SyntaxError: (unicode error) 'rawunicodeescape' codec can't decode bytes in position 107-108: truncated \uXXXX
       [DEBUG   ] Could not LazyLoad saltutil.is_running: 'saltutil' __virtual__ returned False: No module named concurrent
       [ERROR   ] An un-handled exception was caught by salt's global exception handler:

same as https://github.com/saltstack-formulas/dbeaver-formula/issues/6

[myii]

@noelmcloughlin I went into a long description of the issue with Arch Linux on the master branch in the #testing channel on Slack. You can see it here before it disappears in Slack's history:

• https://saltstackcommunity.slack.com/archives/C7KKN9P6W/p1588245779041300

Long story short, py2 support has been removed from Sodium, which is what the current Salt master branch is leading to. So until we figure out how to get the salt-bootstrap to install on Arch py3, this specific Docker image is useless (i.e. netmanagers/salt-master-py2:arch-base-latest). However, both 3000.2 and 2019.2 still work, so please use those instead.

[pull-assistant[bot]]

Best reviewed: commit by commit

---

Optimal code review plan (2 warnings)

test(suite): update travis tests

> `iscsi/osfamilymap.yaml` 67% changes removed in fix(arch): update pa...

     refactor(kitchen): rename arch pillar file

fix(arch): update packages yamls

> `iscsi/osfamilymap.yaml` 50% changes removed in fix(arch): python-co...

     fix(arch): python-configshell-fb dependency problem      ci(archlinux): py2 support removed in salt

Powered by Pull Assistant. Last update 29175d3 ... f78b48f. Read the comment docs.

[commit-lint[bot]]

Tests

• suite: update travis tests (3f34385)

Code Refactoring

• kitchen: rename arch pillar file (141cd9d)

Bug Fixes

• arch: update packages yamls (88a4ff5)
• arch: python-configshell-fb dependency problem (a2b566f)

Continuous Integration

• archlinux: py2 support removed in salt (595a3af)

Contributors

@noelmcloughlin

[noelmcloughlin]

Okay, I was unaware of that. I will use 2019.2 image - Travis passes now

[myii]

@noelmcloughlin Due to conflicts, I rebased this PR on top of master and force pushed. You'll see that your actual commits are all identical except I removed one occurrence of arch-base-latest-master-py2 in kitchen.yml from the first commit. Waiting for the tests to complete now.

---

• Checked using https://github.com/myii/ssf-formula/pull/179

[myii]

@noelmcloughlin I've also modified the main body of the original post so that #33 and #34 are closed automatically. Please adjust that if it isn't correct.

[myii]

@noelmcloughlin Well, Travis is failing again. It looks like a temperamental situation. Please adjust your settings so that you can pull the changes from here before continuing with this. Or if that's too much, perhaps you want to go ahead and merge this and then start a new PR to fix these.

[noelmcloughlin]

I would like to merge this if you are okay with that? Again thanks for your review.

I could take a fresh look at CI some other time.

[saltstack-formulas-travis]

:tada: This PR is included in version 1.1.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: