saltstack-formulas / iscsi-formula

Manage iSCSI Target and Initiator via SaltStack (FreeBSD & GNU/Linux)
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
8 stars 7 forks source link

[BUG] Does not work out of the box, without any pillar #39

Open daks opened 2 years ago

daks commented 2 years ago

Your setup

Formula commit hash / release tag

master version, commit cdb15fb73376e9d07e56bf1be5a333750a7299f5

Versions reports (master & minion)

I used Kitchen setup with image default-debian-11-master-py3

Pillar / config used

I emptied files test/salt/pillar/lvm.example and test/salt/pillar/pillar.example to have no pillar configured. I also modified kitchen.yml to have

       state_top:
         base:
           '*':
             - iscsi

Bug details

Describe the bug

I expect this formula to be usable without any pillar for a minimal setup (like installing the iscsi package only).

Steps to reproduce the bug

With the actions listed previously, simply run

./bin/kitchen converge default-debian-11-master-py3

and highstate ends with 8 failed states and 27 which succeed.

       Succeeded: 27 (changed=17)
       Failed:     8

Expected behaviour

I expect this formula to be usable without any pillar for a minimal setup (like installing the iscsi package only).

Attempts to fix the bug

None

Additional context

None