Issues on Ubuntu - Githubissues

saltstack-formulas / iscsi-formula

Manage iSCSI Target and Initiator via SaltStack (FreeBSD & GNU/Linux)

Other

8 stars 7 forks source link

Closed noelmcloughlin closed 5 years ago

noelmcloughlin commented 5 years ago

This PR should fix four issues which I observed on Ubuntu.

"%s %s".format jinja causes SLS Rendering error. The format() is unnecessary. fix/removed.
The provider and data jinja variables are missing in remove.sls states but are required. fix.
target_core is a kernel module but service.running/dead are not detecting this. To fix, I updated state unless conditionals to ensure kernel module check works.
Also the correct kernel module name is target_core_mod not target_core.

noelmcloughlin commented 5 years ago

Hi @nmadhok would you have time to check this. thx.

noelmcloughlin commented 5 years ago

Hey @nmadhok @gtmanfred could one of you check this? thanks.

nmadhok commented 5 years ago

@noelmcloughlin I missed this as I’m out for a conference. Just merged it!

noelmcloughlin commented 5 years ago

Hope the conference was great!!!! thanks!

nmadhok commented 5 years ago

Still at the conference. It’s until 10/04 but so far so good!

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: