fix(contributing): runnig formula inside container

litnialex commented 4 years ago

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[ ] [feat] A new feature
[ * ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Describe the changes you're proposing

State ID "postgresql-start" is not used anywhere. Changed to "postgresql-running" which is required by server.init.sls.
Added state ID "postgresql-service-reload" which is also required by server.init.sls. It does nothing actually. Does it has to do anything?

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

pull-assistant[bot] commented 4 years ago

Best reviewed: commit by commit

Optimal code review plan (1 warning)

fix(contributing): runnig formula inside container fix(contributing): postgresql-repo state ID requires python3-apt packa...

chore(gemfile.lock): update to latest gem versions (2020-W26) [skip ci...

> `Gemfile.lock` 88% changes removed in chore(upstream): mer...

fix(contributing): postgresql-service-reload type fix(postgres.server): reverted how posrgre.server.image is included chore(upstream): merge Gemfile.lock with upstream docs(container): "postgres:bake_image" specifics

Powered by Pull Assistant. Last update 68a791e ... 904a525. Read the comment docs.

vutny commented 4 years ago

@litnialex Commit linter complains about your commit messages. Would you mind to amend them? https://github.com/saltstack-formulas/postgres-formula/pull/298/checks?check_run_id=837031550

litnialex commented 4 years ago

@litnialex Commit linter complains about your commit messages. Would you mind to amend them? https://github.com/saltstack-formulas/postgres-formula/pull/298/checks?check_run_id=837031550

Done! I also reverted how postgres.server.image is included from postgres/server/init.sls. My previous changes broke running state.apply postgres.server.

I thinks documentation also should be updated. Section regarding postgres.server.image is not actual. There is no sense in running this state separately. It's only intended to replace some parts ofr postgres.server.

vutny commented 4 years ago

I thinks documentation also should be updated. Section regarding postgres.server.image is not actual. There is no sense in running this state separately. It's only intended to replace some parts ofr postgres.server.

Cool, sounds like a great idea. Also, please take a look at conflicting files in your branch.

litnialex commented 4 years ago

@vutny fixed conflicts.

vutny commented 4 years ago

Would you like to update README here or fill in separate PR for it?

litnialex commented 4 years ago

Would you like to update README here or fill in separate PR for it?

Done with 904a5258cd155f3b5a83ec8dc8e990a8ffc6b798

myii commented 4 years ago

Merged, thanks for all of your efforts, @litnialex.

Seems Travis has troubles with bootstrapping Salt on some platforms, but that's OK.

@vutny Appreciate you taking the time to review. The Travis matrix is scheduled for an update to the latest pre-salted images, so this will be resolved soon.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 0.41.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

saltstack-formulas / postgres-formula