chore(version): increase default version; remove pid dir on clean; update pillar.example

noelmcloughlin commented 3 years ago

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[x] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[ ] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[x] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Describe the changes you're proposing

This PR is minor:

use more modern version as default
remove /var/run/postgresql if it exists on clean
update pillar.example version and note on CIDR

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

myii commented 3 years ago

@noelmcloughlin Testing this in the CI would mean adjusting this section here:

https://github.com/saltstack-formulas/postgres-formula/blob/1d34f8c56fc8254bab4d175e465915bd97dec0e1/test/salt/pillar/postgres.sls#L17-L22

Then we'll see which platforms can handle the given version number.

myii commented 3 years ago

@vutny Are you OK if version: 13 is used throughout?

noelmcloughlin commented 3 years ago

@myii thanks for the review - I implemented your suggested changes; version 13 should be fine across all OS.

myii commented 3 years ago

@noelmcloughlin Merged, thanks for the PR. Appreciate the review, @vutny.

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 0.41.9 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

saltstack-formulas / postgres-formula