saltstack-formulas / postgres-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
77 stars 283 forks source link

feat: update all platforms for PostgreSQL 13 (inc. `use_upstream_repo` in CI) #315

Closed myii closed 3 years ago

myii commented 3 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Follow-up for #314, based on this https://github.com/saltstack-formulas/postgres-formula/pull/314#issuecomment-874674266.

Describe the changes you're proposing

Allow PostgreSQL 13 to be installed on all supported platforms.

Update the CI to reflect that by using use_upstream_repo for all possible platforms.

Pillar / config required to test the proposed changes

As provided.

Debug log showing how the proposed changes work

As shown in GitLab CI (Linux) and GitHub Actions (FreeBSD).

Documentation checklist

Testing checklist

Additional context

myii commented 3 years ago

Updated the method here to use two separate tests suites instead of trying to do everything from just the one. Also taking advantage of the share suite to put common controls there.

The benefit to this method is that the formula is being tested fully for both installing from the upstream repo or not. The instances where both methods are available run both suites in the same job.

Part of these changes were automated using https://github.com/myii/ssf-formula/pull/348.

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 0.43.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: