saltstack-formulas / postgres-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
77 stars 283 forks source link

[BUG] Postgesql version install 14 instead of 13 #324

Open teankie opened 2 years ago

teankie commented 2 years ago

Your setup

Formula commit hash / release tag

Release 0.44

Versions reports (master & minion)

Salt Version: Salt: 3004.1

Pillar / config used


      ID: postgresql-repo
Function: pkgrepo.managed
    Name: deb [signed-by=/usr/share/postgresql-common/pgdg/apt.postgresql.org.gpg] http://apt.postgresql.org/pub/repos/apt focal-pgdg main
  Result: True
 Comment: Configured package repo 'deb [signed-by=/usr/share/postgresql-common/pgdg/apt.postgresql.org.gpg] http://apt.postgresql.org/pub/repos/apt focal-pgdg main'
 Started: 12:16:23.219029
Duration: 10943.796 ms
 Changes:   
          ----------
          repo:
              deb [signed-by=/usr/share/postgresql-common/pgdg/apt.postgresql.org.gpg] http://apt.postgresql.org/pub/repos/apt focal-pgdg main

      ID: postgresql-server
Function: pkg.installed
  Result: True
 Comment: The following packages were installed/updated: postgresql-contrib
          The following packages were already installed: postgresql-13
 Started: 12:16:34.163722
Duration: 21929.67 ms
 Changes:   
          ----------
          postgresql-14:
              ----------
              new:
                  14.3-1.pgdg20.04+1
              old:
          postgresql-client-14:
              ----------
              new:
                  14.3-1.pgdg20.04+1
              old:
          postgresql-contrib:
              ----------
              new:
                  14+241.pgdg20.04+1
              old:

Bug details

Describe the bug

We see that when we put version: 13 into the pillar we still see at Ubunut 20.04 LTS that also Postgresql-14 will be installed.

dpkg -l | grep postgres

ii pgdg-keyring 2018.2 all keyring for apt.postgresql.org ii postgresql-13 13.7-1.pgdg20.04+1 amd64 The World's Most Advanced Open Source Relational Database ii postgresql-14 14.3-1.pgdg20.04+1 amd64 The World's Most Advanced Open Source Relational Database ii postgresql-client-13 13.7-1.pgdg20.04+1 amd64 front-end programs for PostgreSQL 13 ii postgresql-client-14 14.3-1.pgdg20.04+1 amd64 front-end programs for PostgreSQL 14 ii postgresql-client-common 241.pgdg20.04+1 all manager for multiple PostgreSQL client versions ii postgresql-common 241.pgdg20.04+1 all PostgreSQL database-cluster manager ii postgresql-contrib 14+241.pgdg20.04+1 all additional facilities for PostgreSQL (supported version)

Steps to reproduce the bug

salt-call state.sls postgres.server

Expected behaviour

We think dat de postgresql-repo must be used the version so OS do not install postgres-14 version

Attempts to fix the bug

You should could update the postgresql-repo with 'deb [signed-by=/usr/share/postgresql-common/pgdg/apt.postgresql.org.gpg] http://apt.postgresql.org/pub/repos/apt focal-pgdg main {version}'. In this case this will be 13.

Additional context