search

saltstack-formulas / samba-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
16 stars 72 forks source link

Add defaults, osmapping yaml for more modular formula #28

Closed noelmcloughlin closed 6 years ago

noelmcloughlin commented 6 years ago

This pull request enhances the formula by introducing the more modular design. Common defaults move to defaults.yaml, os mapping moves to codenamemap.yaml and osmap.yaml. As a further enhancement the samba_config, samba_sections, and samba_users are moved under parent samba ID.

Changelog:

  1. Introduce defaults.yaml for common defaults.
  2. Use map.jinja pattern for OS mapping, promoted by community.
  3. Add Suse support.

This PR resolves #23 and #25 issues and facilitates planned work on Winbind support (#22)

Verification logs: samba_arch.log.txt samba_centos.log.txt samba_suse.log.txt samba_utuntu.log.txt

noelmcloughlin commented 6 years ago

Regression testing.

noelmcloughlin commented 6 years ago

Hi @whiteinge could you please review now.

Verification Logs centos-samba-apache.log.txt suse-samba.log.txt

noelmcloughlin commented 6 years ago

Hi @whiteinge I have added this commit to address #26. Do you think this solution is okay or not?

noelmcloughlin commented 6 years ago

Verification Logs:

Suse Before: suse_before_patch.log.txt

Suse After: suse_after_this_patch.log.txt

Centos: eclipse-samba-centos7.log.txt

noelmcloughlin commented 6 years ago

@gtmanfred Hi Daniel, would appreciate your intput.