search

saltstack-formulas / samba-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
16 stars 72 forks source link

Winbind1: Updated defaults.yaml for smb/winbind defaults #30

Closed noelmcloughlin closed 6 years ago

noelmcloughlin commented 6 years ago

This PR duplicates information from pillar.example to an updated defaults.yaml. Winbind defaults are also introduced to support RFE #30 Existing states/pillar data are not impacted.

noelmcloughlin commented 6 years ago

Facilitates #31 and #32

noelmcloughlin commented 6 years ago

@gravyboat could you review please.

ryanwalder commented 6 years ago

Can we get the 2 WINBIND changes in one PR please. It really makes no sense to have them all split up like this.

Edit: Looking at it looks like the changes from each PR are in the next. Is this the case? they have different hashes for the commits? Do we actually need the first 2 PRs or are all the changes from 1 & 2 included in 3?

noelmcloughlin commented 6 years ago

Hey @ryanwalder Thanks for looking - I was anticipating "the PR is too big" complaint which I sometimes get when adding a new feature - but you are correct that splitting is artificial/confusing.

Please review #32 if you have time - that encapsulates all commits - i.e. you can close #30 and #31 if you approve the feature in #32 . Thanks!

noelmcloughlin commented 6 years ago

See #32 instead.