saltstack-formulas / samba-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
16 stars 72 forks source link

Better handling of default sections #39

Closed rhertzog closed 6 years ago

rhertzog commented 6 years ago

This pull request adds a way to disable the default sections defined in samba/defaults.yaml and it drops the default "files" section which seems to be a misplaced example entry. "homes" and "printers" sections are real default sections however.

mstarostik commented 6 years ago

Just got bitten by this today as well. In fact I don't think any share section should be in the defaults. At least the servers I usually deal with don't export either homes nor printers. These should just be examples, not defaults IMHO.

noelmcloughlin commented 6 years ago

LTGM. thx