saltstack-formulas / samba-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
16 stars 72 forks source link

Ensure winbind package is installed before libs #51

Closed noelmcloughlin closed 5 years ago

noelmcloughlin commented 5 years ago

This PR is to fix dependency issue seen on Ubuntu 18.04.

Some libraries need winbind package installed & configured first or apt breaks.

Feb 12 10:25:19 iedx1 systemd[1]: Failed to start Samba Winbind Daemon.
dpkg: error processing package winbind (--configure):
 installed winbind package post-installation script subprocess returned error exit status 1
dpkg: dependency problems prevent configuration of libpam-winbind:amd64:
 libpam-winbind:amd64 depends on winbind (= 2:4.7.6+dfsg~ubuntu-0ubuntu2.6); however:
  Package winbind is not configured yet.

dpkg: error processing package libpam-winbind:amd64 (--configure):
 dependency problems - leaving unconfigured
dpkg: dependency problems prevent configuration of libnss-winbind:amd64:
 libnss-winbind:amd64 depends on winbind (= 2:4.7.6+dfsg~ubuntu-0ubuntu2.6); however:
  Package winbind is not configured yet.

dpkg: error processing package libnss-winbind:amd64 (--configure):
 dependency problems - leaving unconfigured

I also merged the service.enabled and service.running states.

aboe76 commented 5 years ago

@noelmcloughlin thanks for finding this issue and fixing it

noelmcloughlin commented 5 years ago

Thanks @aboe76 for reviewing.