search

saltstack-formulas / samba-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
16 stars 72 forks source link

section_order ignored #65

Open spirritus opened 5 years ago

spirritus commented 5 years ago

If you specify section_order: ['global'] to only create the global entries for smb.conf this setting is ignored; global, printers and homes (in that order) are always created.

myii commented 5 years ago

@spirritus This could be due to this line:

https://github.com/saltstack-formulas/samba-formula/blob/a80fe6f95257edfabe784ebd9e1dbc46aff0416c/samba/files/smb.conf#L35

Which is yes by default:

https://github.com/saltstack-formulas/samba-formula/blob/778a00febba74ad9a0e6a5bc85839680ae1bb8f8/samba/defaults.yaml#L20

Have you tried setting this to no in your pillar as well as the change you mentioned above?

spirritus commented 5 years ago

He myii, thx for the info, salt is still a bit new to me. That line fixed it.

noelmcloughlin commented 5 years ago

Hi @spirritus
Is "include_unordered_sections: no" a better default? If the current default is unexpected then I'd like to fix that. I'm interested in opinion from Samba user.

spirritus commented 5 years ago

Well, I guess it would be a better default. If you specify a list, then you would expect the list to define what is present and nothing else, unless you specify it with another parameter.

edit: would also delete ''wins support = yes' from default.yaml. excerpt from the docu:

      wins support (G)

           This boolean controls if the nmbd(8) process in Samba will act as a WINS server. You should not set
           this to yes unless you have a multi-subnetted network and you wish a particular nmbd to be your WINS
           server. Note that you should NEVER set this to yes on more than one machine in your network.

           Default: wins support = no