search

saltstack-formulas / zabbix-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
50 stars 121 forks source link

Ignore non-existing groups #100

Closed asenci closed 5 years ago

asenci commented 5 years ago

Make zabbix user group membership optional.

This allow the user to use the same pillar specification for servers running different services. E.g.:

zabbix: user_groups:

The zabbix user will be added to the existing groups on each server and non-existing groups will be ignored.

aboe76 commented 5 years ago

@asenci what is the reason for not introducing a new pillar variable optional_groups for this?

asenci commented 5 years ago

Sorry for the late reply, had a busy week at work.

I used the same pillar variable mainly to keep it simple, but I guess it makes sense as the formula does not control the additional groups?

I can run a few tests and create a new PR using the new "optional_groups" variable, if you think it's better?

aboe76 commented 5 years ago

ow nevermind, I see that user_groups is already in pillar, and this only changes how salt handles it..