saltstack-formulas / zabbix-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
50 stars 121 forks source link

Default fping location is wrong for Debian #124

Open xenadmin opened 4 years ago

xenadmin commented 4 years ago

https://github.com/saltstack-formulas/zabbix-formula/blob/master/zabbix/map.jinja

In 3.0 and upwards, the default fping location is /usr/sbin/fping In the map.jinja it's /usr/bin/fping

In checked the default conf files for 3.0, 4.0, 4,2 and the values FpingLocation and Fping6Location are not defined at all. We have now two choices: Correct the value to the default or stick to the Zabbix defaults and do not define the value at all.

My suggestion would be, to just cut the example values from map.jinja and stick close to the Zabbix defaults, like we did in other issues and PRs.

UPDATE: I did some further tests and it seems like I made a hasty conclusion. I switched my pillar to:

  fpinglocation: /usr/sbin/fping
  fping6location: /usr/sbin/fping6

And my Test Zabbix Proxy stopped working, as Debian 9 obiously has it's fping binaries in /usr/bin so I guess, despite the defaults in the example zabbix_proxy.conf we should stick with /usr/bin/fping