search

saltstack-formulas / zabbix-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
50 stars 121 forks source link

feat(semantic-release): implement for this formula #130

Closed myii closed 4 years ago

myii commented 4 years ago

CC: @hatifnatt @xenadmin.

Very little of this PR touches the existing formula. The one change that had to be made was ensuring that the debconf-utils package is installed before either of the debconf.set states are run. With this fix, Debian 10 is now working and has been included in the testing matrix. This is effectively all of the instances that are passing (with a minor change since then):

Fedora 30 is being incredibly temperamental, intermittently failing, even without changes being made. Restarting the job is usually sufficient. If it really becomes a problem, it can be switched out for Fedora 29, which has been reliable throughout.

myii commented 4 years ago

Fedora 30 just did it again with this PR: it failed the first time but worked when the job was restarted. If it had failed, I was poised to swap it for Fedora 29. We'll keep an eye on it.

myii commented 4 years ago

That was quick, @aboe76!

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 0.21.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

myii commented 4 years ago

Unreliable... it needed multiple restarts again after this merge. I'll switch it to fedora-29 soon.