Closed ricardoklein closed 3 years ago
Best reviewed: commit by commit
Powered by Pull Assistant. Last update 52ded9d ... d343b29. Read the comment docs.
About the lint error... I think this may be caused by using SUSE and SLE in upper case, but, well, this is how it is...
@kleinstuff Apologies for the delay. Let's ask if any of the regular contributors here can have a look at this PR: @hatifnatt @xenadmin @absmith82 -- can any of you help out here?
OK, it's my second PR for formulas, and, I need to admit that it was indeed not a "clean" work. Thank you for your time, I will fix this and reopen it.
Thanks for all of the feedback.
@kleinstuff For the PostgreSQL stuff, I reckon we should put your stuff in a test suite specific to PostgreSQL -- we don't have that right now. So don't feel like you have to throw out the baby with that bathwater! It's still useful stuff, we just need to use it the right way. If you need a hand with that, feel free to ping me and I'll give you some assistance with that.
I suggest closing this and consider it resolved by #146
As suggested closed in favor of #146
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context
If you want, we can also use this pillar example to show how to use this with other formulas to have a complete zabbix server setup: https://gist.github.com/kleinstuff/65929dd3023fba8cc7e7c995a2d6bbf5