saltstack-formulas / zabbix-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
50 stars 121 forks source link

Add suse support #140

Closed ricardoklein closed 3 years ago

ricardoklein commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

If you want, we can also use this pillar example to show how to use this with other formulas to have a complete zabbix server setup: https://gist.github.com/kleinstuff/65929dd3023fba8cc7e7c995a2d6bbf5

pull-assistant[bot] commented 4 years ago
Score: 0.93

Best reviewed: commit by commit


Optimal code review plan

     feat(SUSE): Added (open)SUSE support on base files      bugfix(osfamilymap): Set everything to pgsql      fix(SUSE-support): SLE and Leap working on 15.1 and 15.2 beta

Powered by Pull Assistant. Last update 52ded9d ... d343b29. Read the comment docs.

ricardoklein commented 4 years ago

About the lint error... I think this may be caused by using SUSE and SLE in upper case, but, well, this is how it is...

myii commented 4 years ago

@kleinstuff Apologies for the delay. Let's ask if any of the regular contributors here can have a look at this PR: @hatifnatt @xenadmin @absmith82 -- can any of you help out here?

ricardoklein commented 4 years ago

OK, it's my second PR for formulas, and, I need to admit that it was indeed not a "clean" work. Thank you for your time, I will fix this and reopen it.

myii commented 4 years ago

Thanks for all of the feedback.

@kleinstuff For the PostgreSQL stuff, I reckon we should put your stuff in a test suite specific to PostgreSQL -- we don't have that right now. So don't feel like you have to throw out the baby with that bathwater! It's still useful stuff, we just need to use it the right way. If you need a hand with that, feel free to ping me and I'll give you some assistance with that.

ghormoon commented 3 years ago

I suggest closing this and consider it resolved by #146

hatifnatt commented 3 years ago

As suggested closed in favor of #146