refactor: Use dbapssword consistently across formula

hatifnatt commented 4 years ago

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[ ] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[x] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Related to #83

Describe the changes you're proposing

Use dbapssword instead of dbpass in zabbix-proxy template file. Even though MySQL / PostgreSQL versions of zabbix-proxy is not supported by this formula consistent variable naming across formula would be useful in future.

Pillar / config required to test the proposed changes

Not required. This changes if for "future use".

Debug log showing how the proposed changes work

N/A

Documentation checklist

[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

pull-assistant[bot] commented 4 years ago

Best reviewed: commit by commit

Optimal code review plan

refactor(variable names): use dbpassword consistently across formula

Powered by Pull Assistant. Last update 5b4b787 ... 5b4b787. Read the comment docs.

hatifnatt commented 4 years ago

@xenadmin, @aboe76 could you please take a look. I think it take only few minutes. If this looks good, #83 can be closed too after merging.

xenadmin commented 4 years ago

Looks good to me. But as I only use SQLite I'm not the best to ask.

Ps.: Are @hatifnatt and @aboe76 and @myii back at active work on this formula? If yes, then I'm back to!

myii commented 4 years ago

@hatifnatt I'm just going to send through a commit to fix the failing instances due to the version number tests. The commit message has a typo which could be fixed:

-refactor(variable names): use dbapssword consistently across formula
+refactor(variable names): use dbpassword consistently across formula

@xenadmin Thanks for the review, that's helpful. We're still around, waiting for your contributions!

myii commented 4 years ago

OK, tests fixed by e4952f06f3e2c131a2beb2e30b56f6c3e7b4581a. Do you want to (rebase and) fix the commit message @hatifnatt, or shall we go ahead an merge here?

hatifnatt commented 4 years ago

@xenadmin yes, I know SQLite does not use passwords, but at least you are using proxy part of this formula. Also you are the last person who changed this template. I'm currently upgrading to Zabbix 5 so I can put some effort in to this formula.

@myii yeah, nasty little typo, I'll fix it. Wait a bit.

myii commented 4 years ago

Merged, thanks.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 1.0.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

saltstack-formulas / zabbix-formula