fix(pgsql): do not try to create db and user with schema

ghormoon commented 3 years ago

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[x] [fix] A bug fix I was condering if to make it a feat or fix, but i decided for a fix, because it is not documented that the schema also automatically created DB and User (in i think it shouldn't, that's that zabbix.pgsql.conf is for)

Does this PR introduce a `BREAKING CHANGE`?

Unlikely. I assume that people who want to both create db/user and a schema, use both states, zabbix.pgsql.conf and zabbix.pgsql.schema as documentation says. Potentially someone can be using only zabbix.pgsql.schema and rely on the sideeffect to create a db/user, in that case they need start to use also zabbix.pgsql.conf

Describe the changes you're proposing

Split off required packages to separate state, so zabbix.pgsql.schema can be used independently from zabbix.pgsql.conf. Especially useful if you want to use remote db and for security reasons postgres user cannot login remotely.

Pillar / config required to test the proposed changes

use state zabbix.pgsql.schema

Documentation checklist

[x] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

hatifnatt commented 3 years ago

@ghormoon thanks!

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 1.2.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

saltstack-formulas / zabbix-formula