Added HostInterface and HostInterfaceItem to config

waynegemmell commented 3 years ago

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[x] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

None

Describe the changes you're proposing

My change is a config update. I added HostInterface and HostInterfaceItem to the configuration for the Zabbix Agent. This allows agents to register with the server using their fqdn rather than the IP address. In a cloud environment this is vital because of the mess caused by IP address reuse.

I also added the architecture to the Ubuntu repository because that was playing up.

waynegemmell commented 3 years ago

I don't understand scope as mentioned in the document mentioned above. I hope this was correct.

hatifnatt commented 3 years ago

Yes you get an idea about scope. But can you please rebase and squash all your commits into one, and give it message like feat(agent): add HostInterface and HostInterfaceItem to config of course you need to force push then.

hatifnatt commented 3 years ago

@waynegemmell it doesn't look squashed to me, there is still 6 commits, and in commit d19c8757e2d866d001695979205604a0c4b2a292 you actually bring back empty line which was gone in 2724c7507fac39efe3d12a359f076f0132434a4d Also your previous commit messages was better, you don't need to put whole description inside braces, scope must be something short i.e. agent, server, pillar.example, etc. you can use my suggestion from previous message - feat(agent): add HostInterface and HostInterfaceItem to config

waynegemmell commented 3 years ago

Well that took forever to work through. I think it's finally ok.

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 1.3.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

hatifnatt commented 3 years ago

@waynegemmell thanks for the all effort you put in to made these changes merged :)

waynegemmell commented 3 years ago

Thanks for the patience in this. I learned a lot.

saltstack-formulas / zabbix-formula