fix(repo): update repo config for keyring

waynegemmell commented 1 year ago

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[ ] [feat] A new feature
[x] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

https://github.com/saltstack-formulas/zabbix-formula/issues/160

Describe the changes you're proposing

Newer versions of Ubuntu and Debian have depricated salt-key. While it still works in practice, the errors make salt fail. This update implements the salt-key setting that bypasses it for effected versions of Ubuntu/Debian.

Pillar / config required to test the proposed changes

No changes when using the formula.

Documentation checklist

[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

xenadmin commented 1 year ago

Any reason you don't include Debian 11 and Ubuntu 20.04 for the new method? I had much greater results by doing that on our current Debian 11 machines.

waynegemmell commented 1 year ago

It doesn't seem to work for Focal. I haven't tested Debian 11

hatifnatt commented 1 year ago

Please fix pre-commit lint errors. Also I'm strongly recommend to squash all your commits into one, that's a pretty small change multiple commits reduce readability.

hatifnatt commented 1 year ago

@waynegemmell thanks!

waynegemmell commented 1 year ago

Thanks :)

saltstack-formulas-travis commented 1 year ago

:tada: This PR is included in version 1.3.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

saltstack-formulas / zabbix-formula