saltyhotdog / BattletechIssueTracker

Public issue tracker to communicate with modders and HBS.
MIT License
6 stars 0 forks source link

Stood Up Modifier not factored in melee To Hit #19

Open Sheep-y opened 6 years ago

Sheep-y commented 6 years ago

Describe the location in the code your question is about GetAllMeleeModifiers.ToHit.GetAllMeleeModifiers, method GetAllMeleeModifiers(Mech, ICombatant, Vector3, MeleeAttackType)

What is the question you have about this code? It does not include ToHit.GetStoodUpModifier, which is present in BattleTech.UI.CombatHUDWeaponSlot.UpdateToolTipsMelee(ICombatant).

This can be verified by getting knocked down and then see the melee tooltip. It will say "STOOD UP +4" but total modifier lacks the +4.

Leave any additional comments here Vanilla fix should be as simple as adding one line and changing the sum.

Bug is patched in AIM mod v2.0 which use a unified modifier factor list to make sure actual modifier is same as tooltip modifier, provided that inputs are same.