search

samschott / desktop-notifier

Python library for cross-platform desktop notifications
https://desktop-notifier.readthedocs.io
MIT License
81 stars 8 forks source link

Make base implementation abstract #140

Closed samschott closed 2 weeks ago

samschott commented 2 weeks ago

and use async lock in main class.

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 69.91%. Comparing base (32752cb) to head (793f75e). Report is 31 commits behind head on main.

Files Patch % Lines
src/desktop_notifier/base.py 57.14% 6 Missing :warning:
src/desktop_notifier/main.py 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #140 +/- ## ========================================== - Coverage 71.23% 69.91% -1.32% ========================================== Files 8 8 Lines 657 718 +61 ========================================== + Hits 468 502 +34 - Misses 189 216 +27 ``` | [Flag](https://app.codecov.io/gh/samschott/desktop-notifier/pull/140/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SamSchott) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/samschott/desktop-notifier/pull/140/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SamSchott) | `69.91% <57.89%> (-1.32%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SamSchott#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.