codecov-commenter
commented
1 week ago Codecov Report
Attention: Patch coverage is 58.06452% with 13 lines in your changes missing coverage. Please review.
Project coverage is 75.03%. Comparing base (
32752cb) to head (369c9fa). Report is 75 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| src/desktop_notifier/dbus.py | 55.17% | 13 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #144 +/- ## ========================================== + Coverage 71.23% 75.03% +3.79% ========================================== Files 8 8 Lines 657 833 +176 ========================================== + Hits 468 625 +157 - Misses 189 208 +19 ``` | [Flag](https://app.codecov.io/gh/samschott/desktop-notifier/pull/144/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SamSchott) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/samschott/desktop-notifier/pull/144/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SamSchott) | `75.03% <58.06%> (+3.79%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SamSchott#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Support old DBUS notifications servers which do not conform to the current spec and expect hints in form of
dict[str, str]instead ofdict[str, Variant].This RP also adds older platforms (Ubuntu 20.04 and macOS 12) to the test matrix.
Fixes #143.