search

samschott / maestral

Open-source Dropbox client for macOS and Linux
https://maestral.app
MIT License
3.08k stars 65 forks source link

Missing notifications for local file changes #791

Open knstntnb opened 1 year ago

knstntnb commented 1 year ago

Describe the bug Unfortunately, I am not receiving notifications of any kind, even though the settings in maestral are set to on. Meanwhile, the Mac settings do not show maestral under notifications and therefore are not on - maestral is not asking for permissions within the Mac environment on my end.

To Reproduce (firstly, I installed maestral via homebrew, then removed it completely with an ending reboot) downloaded maestral via GitHub, signed in and authenticated the app to get the token, sync is in progress and notifications in app settings are on while in Mac settings no app permission was requested. App settings for notification have been turned off and on again, no change.

Expected behaviour Notifications would be delivered upon turning settings on + app would be listed within Mac notifications settings.

System:

samschott commented 1 year ago

Permission will be requested not when the checkbox in Maestral's settings is checked, but when attempting to send the first notification.

Can you confirm that you did expect a notification to be sent, for example by manually creating a new folder on the Dropbox website?

Another thing to check: Notifications can be delivered silently, directly to the macOS "notification center", under some circumstances. Do you see any there?

I'm running Ventura 13.1 myself and everything appears to work as expected on my machine.

knstntnb commented 1 year ago

Ah, okay. I just created a folder via the Dropbox website and now Maestral requested permissions to send notifications, so that's good. :)

Maestral is now notifying when an external modified file has been synced to my MacBook (e.g. website to Mac). However, there are no notifications upon syncing directly from the Mac to cloud (e.g. when I saved a new file into that local folder, which is then uploaded) – I suppose that is the default behavior? Then it's simply a misunderstanding on when the notifications are being delivered, sorry.

samschott commented 1 year ago

However, there are no notifications upon syncing directly from the Mac to cloud

Yes, that is indeed the expected behaviour. Maybe this can be clarified in the checkbox text, for example: "Notify for remote file changes".

Would you think that notifications for local changes are helpful? I always assumed that they add little value.

knstntnb commented 1 year ago

Yes, that is indeed the expected behaviour. Maybe this can be clarified in the checkbox text, for example: "Notify for remote file changes".

I think that's a good idea to clarify the setting option a little bit more, rules out misunderstandings.

Would you think that notifications for local changes are helpful? I always assumed that they add little value.

For my use case, yes, as I'm used to them with other syncing apps and always think something didn't sync. But I know that others won't need that information and will be annoyed by so many notifications. So maybe providing an option to opt-out on that notification-variant is an option, or combining them into a global notification off-setting?