search

samvera-labs / nurax-pre2023

Vanilla-plus Hyrax app for testing and tire-kicking
https://nurax-dev.curationexperts.com
Other
8 stars 18 forks source link

Maintain Visibility Setting When Transferring Ownership of a Work #135

Closed chrisdaaz closed 6 years ago

chrisdaaz commented 6 years ago

Descriptive summary

When you transfer a work to another user, the work's visibility setting is changed to Private. Work ownership transfers should maintain the visibility settings of the work as they were before the transfer.

Rationale

The unexpected change in visibility settings adds a task for a user when they accept ownership of a public, embargoed, or institution-only work. The new owner of the work might not know the original visibility setting of the work. This creates confusion.

Expected behavior

Visibility settings should not change during the ownership transfer between users.

Actual behavior

Visibility is changed to Private for all transferred works.

Steps to reproduce the behavior

  1. User A creates a Work and sets the visibility to public (makes sure the admin set the does not have a mediated workflow activated)
  2. User A transfers the work to User B
  3. User B accepts the work
  4. Check the visibility status
jcoyne commented 6 years ago

Is this bug specific to Nurax or should it be in the Hyrax repo?

julesies commented 6 years ago

@jcoyne i can't tell if it exists on 2.0 since nurax is on CE branch now. if 2.0, then it needs to move. @vantuyls was going to check his local set up, unless you know!

chrisdaaz commented 6 years ago

I first noticed this on my institution's app, which is on Hyrax 1.04, so I doubt this is specific to NURAX.

julesies commented 6 years ago

@chrisdaaz ah thanks! move to hyrax then!

chrisdaaz commented 6 years ago

Moved to https://github.com/samvera/hyrax/issues/2293

julesies commented 6 years ago

@chrisdaaz is this resolved?

julesies commented 6 years ago

@chrisdaaz nvm i see it's open.