samvera-labs / nurax-pre2023

Vanilla-plus Hyrax app for testing and tire-kicking
https://nurax-dev.curationexperts.com
Other
8 stars 18 forks source link

should admin sets have the same icons as collections now? #139

Closed julesies closed 6 years ago

julesies commented 6 years ago

Looks like in this view, Admin sets share an icon with works, maybe it should match collections?

screen shot 2017-12-01 at 4 38 08 pm

elrayle commented 6 years ago

@ggeisler Seems like a UI/UX judgement call.

ggeisler commented 6 years ago

I agree that the icon for Admin Set should be the same one used for Collection, rather than the one for a work.

elrayle commented 6 years ago

https://github.com/samvera/hyrax/issues/2603

julesies commented 6 years ago

Okay for new admin sets this work, but for existing, they show the work icon

screen shot 2018-04-05 at 10 28 31 am

elrayle commented 6 years ago

@vantuyls This is a case of existing admin sets created in pre-2.1.0. The default icon is not just used, it is assigned. So if we want to update it for all, the migration service would need to...

OPTION 1: Don't change default icons for existing admin sets (time estimate: 0) OPTION 2: Use the process described above to have the migration service update the default icon (time estimate: ?)

julesies commented 6 years ago

Decision was to not update existing admin set icons pre 2.1