search

samvera-labs / nurax-pre2023

Vanilla-plus Hyrax app for testing and tire-kicking
https://nurax-dev.curationexperts.com
Other
8 stars 18 forks source link

As an account with proxy permissions - editing shows proxies #243

Open julesies opened 6 years ago

julesies commented 6 years ago

Descriptive summary

If you are logged in with an account that has been granted proxy status, and you are editing a work that is not yours, nor one of your proxies - the "on behalf of" shows all your proxies. AFAICT, this is just a UX issue and no permissions are altered on edit, but it's confusing/alarming to the user.

Rationale

It feels pretty alarming

Expected behavior

When editing a work, you are defaulting to your own account? When editing a work, no proxies are shown? When editing a work of someone else, you don't see unrelated proxy accounts that shouldn't have permissions on the work you are editing.

Actual behavior

screen shot 2018-03-20 at 12 25 39 pm

Steps to reproduce the behavior

  1. log into an account that has been given proxy status by 1 or more people
  2. go to a work that you have permission to edit, but not by being a proxy
  3. edit the work and note the "on behalf of"
newmanld commented 6 years ago

See also https://github.com/samvera/hyrax/issues/2822

vantuyls commented 6 years ago

Proxy Indicator (On Behalf Of area) should be aware of the context it is working in.

For depositing, this dialog is performing as expected: show me all of the users on behalf of whom i can deposit

For editing, this dialog is problematic: the dialog here should be aware of the context it is working in. It should show the proxy information for the user the item was originally deposited on behalf of. For Instance, if Steve is a proxy for Linda, and he deposits Linda's article, when Steve goes to edit Linda's article, the On Behalf Of area of this page should only show Linda's name.

julesies commented 6 years ago

What if you are editing as an admin or metadata librarian?

vantuyls commented 6 years ago

Okay, after back and forth with @julesies i think we're settled on the following: Solution to this issue: when Editing a work as a proxy, the Oh Behalf Of area of the form should default to the Owner of the work.

No other proxies should show in this drop down as additional names in the drop down would suggest that one could be editing the work on behalf of a third party, which is not behavior we want to express in the system at this time.

julesies commented 6 years ago

With beta2, now as an admin, I'm seeing it default to my account so it's better than screenshot. still odd to see the other unrelated proxies.