search

sandalle / minecraft_bigreactor_control

Minecraft BigReactor Computercraft Control Program
MIT License
76 stars 41 forks source link

Stop overzealous controlRodAdjustAmount adjustment amount adjustment #56

Closed thetaphi closed 9 years ago

thetaphi commented 9 years ago

The amount of the words "adjustment" and "amount" in the title needs to be adjusted.

Nevertheless, from the commit message:

It makes one reactor mess with the others. I guess it makes sense for one reactor setups to carry over between cycles, but as soon as there's more, you're in for surprises. More so since that variable is also used for the manual adjustment amount.

Figured that out while I was testing the new UI handlers from thetaphi@669e07972a38dcdc2b4a7f0ad6cadd1a89bd02da

mechaet commented 9 years ago

Wait, what? The individual reactors are all supposed to be loading and saving their own variables from their own config files. Was there a regression in config file functionality somewhere??

Date: Mon, 6 Apr 2015 22:26:54 -0700 From: notifications@github.com To: minecraft_bigreactor_control@noreply.github.com Subject: [minecraft_bigreactor_control] Stop overzealous controlRodAdjustAmount adjustment amount adjustment (#56)

The amount of the words "adjustment" and "amount" in the title needs to be adjusted.

Nevertheless, from the commit message:

It makes one reactor mess with the others. I guess it makes sense for

one reactor setups to carry over between cycles, but as soon as there's

more, you're in for surprises. More so since that variable is also used

for the manual adjustment amount.

Figured that out while I was testing the new UI handlers from thetaphi@669e079

You can view, comment on, or merge this pull request online at: https://github.com/sandalle/minecraft_bigreactor_control/pull/56

Commit Summary

Count active reactors for steam capacity calculation Revert "Count active reactors for steam capacity calculation" add .swp to .gitignore Count active reactors for steam capacity calculation Revert "Count active reactors for steam capacity calculation" add .swp to .gitignore Merge branch 'master' of https://github.com/thetaphi/minecraft_bigreactor_control Don't manipulate controlRodAdjustAmount

File Changes

M
.gitignore
(1)

M
lolmer_bigreactor_monitor_prog.lua
(10)

Patch Links:

https://github.com/sandalle/minecraft_bigreactor_control/pull/56.patch https://github.com/sandalle/minecraft_bigreactor_control/pull/56.diff

— Reply to this email directly or view it on GitHub.

thetaphi commented 9 years ago

AFAICT, that particular reactor setting slipped through the cracks from the start. I tried bisecting but couldn't find a good revision.

So from what you say, a better approach than always leaving the adjustment value at 1 would be to a) kill the global and b) put the setting in the config file for each reactor via _G?