sandalle / minecraft_bigreactor_control

Minecraft BigReactor Computercraft Control Program
MIT License
76 stars 41 forks source link

New Control Algorithms #74

Closed mattsoulanille closed 8 years ago

mattsoulanille commented 8 years ago

I think your program is awesome, and I have used it for every reactor I have built. I thought I'd try a different control algorithm by implementing a PID controller. For reactors, it targets a user-defined temperature, and I have repurposed the control rod adjustment arrows to control the target temperature. For turbines, it targets whatever speed the user sets (as before). I have found that it can be more stable than the current algorithm. Would you give it a try and let me know what you think?

mechaet commented 8 years ago

This looks like a more mathematically-correct way of doing what I was doing with the kick mechanism (which was based off of an HVAC control system I worked on); I didn't realize the other inputs available from the reactor object.

Looks good to me, @sandalle ?

sandalle commented 8 years ago

Thank you @mattsoulanille, this looks like some awesome work! I'll do some test runs on this, plus I have a few other queued updates to test/fix, and then I'll put out a 0.3.18 release hopefully later this week.

sandalle commented 8 years ago

http://pastebin.com/GzZwuV8w (http://pastebin.com/fguScPBQ is the stable branch, currently 0.3.17) has been updated with this code for those wanting to also give it a run.