Energy buffer rounded to nearest percentage

[Viper007Bond]

Despite the decimal in the display, the energy percentage shown is being rounded to the nearest full integer.

Big Reactors 0.3.3A ComputerCraft 1.63

[sandalle]

Sorry for the delay, I didn't get a message stating that this issue was opened. I'll look into this. There is some rounding code used and the display seems to like including a decimal place or two even when I ask it not to (or I forgot to commit that change ;)).

[Viper007Bond]

The reactors can buffer quite a bit so I think there's nothing wrong with showing tenths of a percent. It gives you a more accurate view of your reactor status. The normal GUI of the reactor shows tenths in its display as well.

[sandalle]

The GUI shows hundredths of a percent for RF/t and then only full integers for buffer. I'll try to follow suite for the GUI. Where I've seen this issue most on displaying rounded numbers even when I don't want it is for the reactor control rods. Those only go whole percentages anyways, but the LUA print keeps putting a ".0" after it. Turbine RF/t are in whole numbers, though RPMs are in tenths of an RPM. Max Flow is in full mB/t integers.

[sandalle]

Goals to match in-game Big Reactors:

• All reactors:
  • Temperature in whole digits celsius (300^C)
  • Fuel consumption in thousandths (0.084 mB/t)
  • Reactivity in full percents (100%)
• Passively cooled reactors:
  • RF/t in hundredths (0.00 RF/t)
  • Energy buffer in RF integers (10,000,000 RF)
• Actively cooled reactors:
  • Hot fluid output in mB/t integers (3,911 mB/t)
  • Water/Steam tanks in mB integers (21,800 mB)
• Turbines:
  • Rotor speed in tenths of an RPM (2,380.7 RPM) in GUI text, whole integers (2,381) in bar graph.
  • Energy output in RF/t integers (11,558 RF/t)
  • Rotor efficiency in integers (100%)
  • Max flow in mB/t integers (2,000 mB/t)
  • Intake/Exhaust Fluid tanks in mB integers (2,000 mB)
  • Energy buffer in RF integers (1,000,000 RF).

[Viper007Bond]

I'm talking about the energy buffer percentage, not raw RF value. The energy buffer shows tenths in the normal GUI: https://i.imgur.com/mZpHZYn.png (76.8% in this screenshot)

But your UI rounds that: https://i.imgur.com/CHCoJAa.png (57.0% in this screenshot)

I'm using a passively cooled reactor at the moment and sorry for all the periods in the screenshots. It's the one thing I hate about the Sphax texture pack.

[sandalle]

This is fixed in the master branch and will go out as 0.3.9 Soon(TM). :)

[Viper007Bond]

Cool, thanks!