Y24-157 - Soft delete of a location

sanger / labwhere

A tool for tracking uniquely barcoded labware

MIT License

3 stars 10 forks source link

Y24-157 - Soft delete of a location #797

Open seenanair opened 2 weeks ago

seenanair commented 2 weeks ago

User story As a LabWhere user, I would like to soft delete a location that may no longer be in use or is misspelled. This allows for a cleaner UI and avoids unnecessary location names dangling around.

Who are the primary contacts for this story Tristram Bellerby

Acceptance criteria To be considered successful the solution must allow:

[ ] Delete button should be visible next to a location on the locations page on Labwhere
[ ] Pressing the Delete button will prompt for confirmation.
[ ] If confirmed, the location is removed from the UI (but retained in the database)
[ ] Users should not allowed to scan labware in and out of soft-deleted locations

KatyTaylor commented 1 week ago

I guess that we should also prevent users from scanning labware into or out of locations that have been soft-deleted?

TWJW-SANGER commented 4 days ago

Just on Katy's point. I can see the point of preventing or warning people scanning labware into a soft-deleted location.

I am less sure why we would prevent users scanning labware currently in a soft-deleted location out of it or into another location ?

If we did prevent them - what would we expect them to do next? What errors are we preventing?

seenanair commented 4 days ago

@TWJW-SANGER @KatyTaylor Hmm, that brings up another question: should we allow deletion of locations with labware inside them or should we prompt users to move the labware elsewhere before deletion?

KatyTaylor commented 4 days ago

And if you soft delete locations with other locations inside them, does it also soft delete the child locations?

KatyTaylor commented 4 days ago

Scanning out:

I guess if they're scanning out it's because they forgot to do it when the location was 'deleted', so we could let them do it
Or, we could automatically scan-out any labware in a location when it's deleted (and tell the user we're doing so)
Or ask users to scan them elsewhere like Seena suggests - but this could cause issues as the users might not know what those labware are.

Scanning into another location:

Agreed we shouldn't prevent a labware being scanned into a different location, just because it's in a 'deleted' location for some reason.

Child locations:

I think we should ask for explicit confirmation from the user before deleting child locations too - like get them to check a box next to all the ones they want to delete or something