Update rubocop-performance 1.22.1 → 1.23.0 (minor)

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-performance (1.22.1 → 1.23.0) · Repo · Changelog

Release Notes

1.23.0

New features

#474: Add new Performance/StringBytesize cop. (@viralpraxis)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 7 commits:

✳️ rubocop (1.67.0 → 1.68.0) · Repo · Changelog

Release Notes

1.68.0

New features

#13050: Add new Style/BitwisePredicate cop. (@koic)

#12140: Add new Style/CombinableDefined cop. (@dvandersluis)

#12988: Add new Style/AmbiguousEndlessMethodDefinition cop. (@dvandersluis)

#11514: Add new Lint/UnescapedBracketInRegexp cop. (@dvandersluis)

#13360: Add AllowSteepAnnotation config option to Layout/LeadingCommentSpace. (@tk0miya)

#13146: Add new IgnoreDuplicateElseBranch option to Lint/DuplicateBranch. (@fatkodima)

#13171: Add new Style/SafeNavigationChainLength cop. (@fatkodima)

#13252: Add new Style/KeywordArgumentsMerging cop. (@fatkodima)

Bug fixes

#13401: Fix a false negative for Style/RedundantLineContinuation when there is a line continuation at the EOF. (@koic)

#13368: Fix an incorrect autocorrect for Naming/BlockForwarding with Style/ExplicitBlockArgument. (@koic)

#13391: Fix deserialization of unknown encoding offenses. (@earlopain)

#13348: Ensure Style/BlockDelimiters autocorrection does not move other code between the block and comment. (@dvandersluis)

#13382: Fix an error during error handling for custom ruby extractors when the extractor is a class. (@earlopain)

#13309: Fix a false negative for Lint/UselessAssignment cop when there is a useless assignment followed by a block. (@pCosta99)

#13255: Fix false negatives for Style/MapIntoArray when using non-splatted arguments. (@vlad-pisanov)

#13356: Fix a false positive for Layout/SpaceBeforeBrackets when there is a dot before []=. (@earlopain)

#13365: Fix false positives for Lint/SafeNavigationConsistency when using safe navigation on the LHS with operator method on the RHS of &&. (@koic)

#13390: Fix false positives for Style/GuardClause when using a local variable assigned in a conditional expression in a branch. (@koic)

#13337: Fix false positives for Style/RedundantLineContinuation when required line continuations for && is used with an assignment after a line break. (@koic)

#13387: Fix false positives in Style/RedundantParentheses when parentheses are used around method chain with do...end block in keyword argument. (@koic)

#13341: Fix false positives for Lint/SafeNavigationChain when a safe navigation operator is used with a method call as the RHS operand of && for the same receiver. (@koic)

#13324: Fix --disable-uncorrectable to not insert a comment inside a string continuation. (@dvandersluis)

#13364: Fix incorrect autocorrect with Lint/UselessAssignment a multiple assignment or for contains an inner assignment. (@dvandersluis)

#13353: Fix an incorrect autocorrect for Style/BlockDelimiters when EnforcedStyle: semantic is set and used with Layout/SpaceInsideBlockBraces. (@koic)

#13361: Fix false positives for Style/RedundantInterpolationUnfreeze and Style/RedundantFreeze when strings contain interpolated global, instance, and class variables. (@vlad-pisanov)

#13343: Prevent Layout/LineLength from breaking up a method with arguments chained onto a heredoc delimiter. (@dvandersluis)

#13374: Return exit code 0 with --display-only-correctable and --display-only-safe-correctable when no offenses are displayed. (@dvandersluis)

#13193: Fix false positive in Style/MultipleComparison when ComparisonsThreshold exceeds 2. (@fatkodima,@vlad-pisanov)

#13325: Fix an incorrect autocorrect for Lint/NonAtomicFileOperation when using a postfix unless for file existence checks before creating a file, in cases with Dir.mkdir. (@kotaro0522)

#13397: Update PercentLiteralCorrector to be able to write pairs of delimiters without excessive escaping. (@dvandersluis)

#13336: Update Style/SafeNavigation to not autocorrect if the RHS of an and node is an or node. (@dvandersluis)

#13378: When removing parens in Style/TernaryParentheses with a send node condition, ensure its arguments are parenthesized. (@dvandersluis)

Changes

#13347: When running rubocop -V, show the analysis Ruby version of the current directory. (@earlopain)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 71 commits:

↗️ json (indirect, 2.7.4 → 2.8.2) · Repo · Changelog

Release Notes

2.8.2

What's Changed

JSON.load_file: explictly load the file as UTF-8

Full Changelog: v2.8.1...v2.8.2

2.8.1

Fix the java version of the package to include the extension implementation. Only concerns JRuby.

Full Changelog: v2.8.0...v2.8.1

2.8.0

What's Changed

Emit a deprecation warning when JSON.load create custom types without the create_additions option being explictly enabled.
- Prefer to use JSON.unsafe_load(string) or JSON.load(string, create_additions: true).
Emit a deprecation warning when serializing valid UTF-8 strings encoded in ASCII_8BIT aka BINARY.
Bump required Ruby version to 2.7.
Add support for optionally parsing trailing commas, via allow_trailing_comma: true, which in cunjunction with the
pre-existing support for comments, make it suitable to parse jsonc documents.
Many performance improvements to JSON.parse and JSON.load, up to 1.7x faster on real world documents.
Some minor performance improvements to JSON.dump and JSON.generate.

Parsing performance

Parsing performance is improved by 50-70% on realistic benchmarks, and even more on micro-benchmarks: https://gist.github.com/casperisfine/cf4b3a0594fae24b7d0eb93daaf3841a

== Parsing activitypub.json (58160 bytes)
ruby 3.4.0dev (2024-11-06T07:59:09Z precompute-hash-wh.. 7943f98a8a) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
          json 2.7.2   638.000 i/100ms
                  oj   798.000 i/100ms
          Oj::Parser   948.000 i/100ms
           rapidjson   631.000 i/100ms
Calculating -------------------------------------
          json 2.7.2      6.423k (± 1.3%) i/s  (155.70 μs/i) -     32.538k in   5.067149s
                  oj      7.989k (± 1.0%) i/s  (125.17 μs/i) -     40.698k in   5.094544s
          Oj::Parser      9.472k (± 1.3%) i/s  (105.58 μs/i) -     47.400k in   5.005119s
           rapidjson      6.354k (± 1.1%) i/s  (157.37 μs/i) -     32.181k in   5.064962s

Comparison:
          json 2.8.0:     9510.0 i/s
          Oj::Parser:     9471.9 i/s - same-ish: difference falls within error
                  oj:     7989.4 i/s - 1.19x  slower
          json 2.7.2:     6422.5 i/s - 1.48x  slower
           rapidjson:     6354.5 i/s - 1.50x  slower

== Parsing twitter.json (567916 bytes)
ruby 3.4.0dev (2024-11-06T07:59:09Z precompute-hash-wh.. 7943f98a8a) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
          json 2.7.2    52.000 i/100ms
                  oj    64.000 i/100ms
          Oj::Parser    76.000 i/100ms
           rapidjson    57.000 i/100ms
Calculating -------------------------------------
          json 2.7.2    526.860 (± 3.8%) i/s    (1.90 ms/i) -      2.652k in   5.042680s
                  oj    631.234 (± 1.7%) i/s    (1.58 ms/i) -      3.200k in   5.070973s
          Oj::Parser    764.354 (± 3.5%) i/s    (1.31 ms/i) -      3.876k in   5.077736s
           rapidjson    579.085 (± 2.8%) i/s    (1.73 ms/i) -      2.907k in   5.024620s

Comparison:
          json 2.8.0:      884.0 i/s
          Oj::Parser:      764.4 i/s - 1.16x  slower
                  oj:      631.2 i/s - 1.40x  slower
           rapidjson:      579.1 i/s - 1.53x  slower
          json 2.7.2:      526.9 i/s - 1.68x  slower

== Parsing citm_catalog.json (1727030 bytes)
ruby 3.4.0dev (2024-11-06T07:59:09Z precompute-hash-wh.. 7943f98a8a) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
          json 2.7.2    30.000 i/100ms
                  oj    35.000 i/100ms
          Oj::Parser    45.000 i/100ms
           rapidjson    40.000 i/100ms
Calculating -------------------------------------
          json 2.7.2    304.584 (± 3.3%) i/s    (3.28 ms/i) -      1.530k in   5.029021s
                  oj    358.572 (± 0.8%) i/s    (2.79 ms/i) -      1.820k in   5.076123s
          Oj::Parser    450.643 (± 3.1%) i/s    (2.22 ms/i) -      2.295k in   5.098150s
           rapidjson    395.304 (± 1.5%) i/s    (2.53 ms/i) -      2.000k in   5.060537s

Comparison:
          json 2.8.0:      449.8 i/s
          Oj::Parser:      450.6 i/s - same-ish: difference falls within error
           rapidjson:      395.3 i/s - 1.14x  slower
                  oj:      358.6 i/s - 1.25x  slower
          json 2.7.2:      304.6 i/s - 1.48x  slower

Full Changelog: v2.7.3...v2.8.0

2.7.6

Fix a regression in JSON.generate when dealing with Hash keys that are string subclasses, call to_json on them.

Full Changelog: v2.7.5...v2.7.6

2.7.5

What's Changed

Fix a memory leak when #to_json methods raise an exception.

Gracefully handle formatting configs being set to nil instead of "".

Workaround another issue caused by conflicting versions of both json_pure and json being loaded.

Full Changelog: v2.7.4...v2.7.5

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parser (indirect, 3.3.5.0 → 3.3.6.0) · Repo · Changelog

Release Notes

3.3.6.0 (from changelog)

API modifications:

Bump maintenance branches to 3.3.6 (#1045) (Koichi ITO)

3.3.5.1 (from changelog)

API modifications:

Bump maintenance branches to 3.2.6 (#1044) (Koichi ITO)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 9 commits:

↗️ rubocop-ast (indirect, 1.32.3 → 1.36.1) · Repo · Changelog

Release Notes

1.36.1 (from changelog)

Bug fixes

#339: Do not emit a deprecation warning for EnsureNode#body to give RuboCop a chance to update its usage. EnsureNode#body will still be changed in the next major version of rubocop-ast. (@earlopain)

1.36.0 (from changelog)

Changes

#337: Deprecate EnsureNode#body in favour of EnsureNode#branch. EnsureNode#body will be redefined in the next major version of rubocop-ast. (@dvandersluis)

1.35.0 (from changelog)

New features

#333: Add BeginNode for kwbegin nodes. (@dvandersluis)

Changes

#333: Add EnsureNode#rescue_node method. (@dvandersluis)

1.34.1 (from changelog)

New features

#329: Add Node#type? to reduce complexity of checking against multiple node types. (@dvandersluis)

#330: Extend Node#const_name to casgn nodes. (@dvandersluis)

Bug fixes

#331: [Fix #331] Fix crash in OpAsgnNode#name when the lhs is a send or csend node. (@dvandersluis)

1.34.0 (from changelog)

New features

#326: Introduce lhs and rhs aliases to assignment nodes for consistency. (@dvandersluis)

1.33.1 (from changelog)

Bug fixes

#325: Allow non_bare_access_modifier_declaration? to handle modifiers with multiple arguments. (@dvandersluis)

1.33.0 (from changelog)

New features

#203: Add classes for masgn and mlhs nodes. (@dvandersluis)

#204: Add VarNode class for lvar, ivar, cvar and gvar node types. (@dvandersluis)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 45 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@depfu rebase
Rebases against your default branch and redoes this update

@depfu recreate
Recreates this PR, overwriting any edits that you've made to it

@depfu merge
Merges this PR once your tests are passing and conflicts are resolved

@depfu cancel merge
Cancels automatic merging of this PR

@depfu close
Closes this PR and deletes the branch

@depfu reopen
Restores the branch and reopens this PR (if it's closed)

@depfu pause
Ignores all future updates for this dependency and closes this PR

@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR

@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

sanger / labwhere