search

sanity / Athena

An efficient in-memory data structure supporting arbitrary boolean queries See README file below for more information.
74 stars 1 forks source link

Use a proper logging framework #7

Open sanity opened 14 years ago

sanity commented 14 years ago

Right now the only logging is through a primitive and ugly static final boolean StoreIterator.verbose. We should use proper logging (provided it doesn't slow anything down).

KushalP commented 14 years ago

What do we need to log?

Are you talking about setting up a way to write the DB to file? If so, surely an append-only filesystem would be easiest to implement and best in terms of concurrency?

sanity commented 14 years ago

No, I just mean a logging framework, like log4j or something - for debugging purposes.

KushalP commented 14 years ago

Ah, okay. I'll set up the dependency for it now.

sanity commented 14 years ago

Is log4j the best option? I've never found a Java logging framework I liked, they all seem over-complicated.

Anyway, I guess we can go with whatever option you prefer.

KushalP commented 14 years ago

These are our options, and two of them use log4j: http://en.wikipedia.org/wiki/Java_logging_framework#Comparison_of_features

sanity commented 14 years ago

Ok, log4j sounds good