search

saratscheff / ether-monitor

3 stars 0 forks source link

When calculating arbitrage, it should compare BID & ASK #1

Closed agustinf closed 7 years ago

agustinf commented 7 years ago

We can see here https://github.com/psaratscheff/ether-monitor/blob/master/controllers/arbitrageCtrl.js#L67 that to determine an arbitrage opportunity the bot is comparing local BID/ASK with an average international price.

I think we should compare the maximum BID of one exchange with the minimum ASK on the other exchange and vice versa. When the local maximum BID is higher than the minimum ASK on the other exchange, I can sell over there and buy over here.

saratscheff commented 7 years ago

Fully agree! When this code was written, no API was found for Lykke (The exchange being used at the moment). But now: https://api.lykkex.com/swagger/ui/index/index.html Also, support for Kraken should be considered: https://www.kraken.com/help/api

Definitely putting both implementations on the roadmap.

saratscheff commented 7 years ago

Fixed: ec6b3bf4126f63f795096a08424be44f4fa8af73