sashankshukla / splash

2 stars 0 forks source link

Melinda/no results #96

Closed mgp2542 closed 1 year ago

mgp2542 commented 1 year ago

In the case that a call to fetch is fulfilled and returns 0 results, we would want to show this component instead of the LoadingSpinner.

mgp2542 commented 1 year ago

Sounds good! Just as long as all the logic is still workin. Also, we will need to figure out a more accurate way of assessing when ApprovalCards is still loading in the SellerDashboard since check for 0 now lends to No Results scenario

On Jul 26, 2023, at 06:44, Sashank @.***> wrote:

 @sashankshukla commented on this pull request.

i think we can make this slightly better looking for no results than a simple text. I'll push an example up there are plenty of cool message handle pages for things like no results 404 erros etc.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.