search

satago / tapestry-jpa-transactions

Advanced transaction support for tapestry JPA applications
Apache License 2.0
4 stars 2 forks source link

Permit to merge the codebase to Apache Tapestry 5.5 and IP clearance? #2

Open kaosko opened 8 years ago

kaosko commented 8 years ago

@dmitrygusev, I'd like to merge your module to Apache Tapestry 5.5. Would you be ok with it and support the merge? Your module is more advanced and I don't see any compelling reason to maintain multiple implementations of JPA support. If you agree, we'd need to track down all contributors to your module and have them agree as well. I see one pull request that's not merged but are there any other contributors in addition to you?

dmitrygusev commented 8 years ago

Hey Kalle,

Me and the rest of the Satago Team, including @pedrocborges and @adamhorner -- CTO of Satago, are all for it. There shouldn't be any other contributors to the library.

That pull request #1 still stays, and would be nice to fix addressed bug before releasing this as a part of T5.5. It needs some work, meaning that I'd like to change the fix from that PR a little, ideally covered with some tests. What stops me is that this project doesn't have any test infrastructure at the moment, and I don't have the need of fixing the bug right now: there is a workaround that works for our projects.

kaosko commented 8 years ago

Thanks @dmitrygusev, that's excellent. Do you mean there are no other contributors to this library besides yourself or in addition to @pedrocborges and @adamhorner? If the latter, can you guys comment on this issue as well so we have an agreement on file from everybody involved. Yeah, perhaps best to merge the pull request first and then work it into T5. I'll see what I can do myself.

adamhorner commented 8 years ago

Hi Kalle, @pedrocborges and I are the only other contributors. I'm very happy for you to merge the code (which is mainly the work of @dmitrygusev) into the core codebase for T5. I'll get Pedro to comment too, let us know if there is any other way we can help. Thanks, Adam.

ghost commented 8 years ago

Hi Kalle, like @adamhorner said we're all in favour of pushing this into the tapestry stack. I just second the concerns of @dmitrygusev about the two small issues we found while using it in our own web-app.

kaosko commented 8 years ago

I made an initial license review of the codebase. Given that this codebase is already under Apache License V2, there's no need for you to necessary sign ICLA or CCLA (Individiual Contributor License Agreement or Corporate Contributor License Agreement). However, you've explicitly mentioned that Satago Ltd. owns copyright to the works (instead of individual authors). Your company will retain copyrights to the lines of code you've written but I'd ask you to remove the copyright line form each individual file (the license notice should stay). Instead, we'll add a NOTICE file to the module and notice your copyrights there. It's an ASF recommendation that the donating party modifies the copyright notices themselves instead of ASF committers. See http://www.apache.org/legal/src-headers.html#faq-why for more info. I'll send a few pull requests your way in the coming days.