search

savoirfairelinux / flake8-copyright

Adds copyright checks to flake8
GNU Lesser General Public License v3.0
15 stars 15 forks source link

Ignore empty files #6

Closed dobesv closed 8 years ago

ghost commented 8 years ago

I don't understand the reason of this PR. With a nonzero copyright_min_file_size, we will already ignore empty files. Why add this logic?

dobesv commented 8 years ago

This also ignores files that contain some white space, maybe someone put a newline the init file for the package. It's a trivial thing, feel free to reject it. It just seemed simpler than coming up with a "correct" minimum size to use.

On Thu, Jun 16, 2016, 8:09 AM Virgil Dupras notifications@github.com wrote:

I don't understand the reason of this PR. With a nonzero copyright_min_file_size, we will already ignore empty files. Why add this logic?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/savoirfairelinux/flake8-copyright/pull/6#issuecomment-226514643, or mute the thread https://github.com/notifications/unsubscribe/AAUAmYayiqp2-LsiygicFeynirQARXOhks5qMWb_gaJpZM4I2xkp .

ghost commented 8 years ago

I'll do that then.