search

sawhney17 / logseq-automatic-linker

MIT License
97 stars 18 forks source link

Add stop-words for GTD #3

Closed yanyaoer closed 2 years ago

yanyaoer commented 2 years ago

Awesome. Thanks for the PR! Any reason by you chose to use .name and then convert it to uppercase? Just take the originalName instead of name and it should be uppercase by default.

compare with uppercase make it work correct, even logseq.app change the originalName's output

sawhney17 commented 2 years ago

Looks good. Just add DOING, etc to the list and we should be good to go.

robotii commented 2 years ago

Hi,

I have similar functionality available in my PR #6

Would you be open to working with that to get the default list correct? I have made it a configuration option, so the user can add their own list of stop words.

The default configuration is found at https://github.com/robotii/logseq-automatic-linker/blob/feature/link-as-tags/index.ts#L50

sawhney17 commented 2 years ago

Thank you for your contribution, I have however chosen to merge @robbotii's implementation as that was a bit more robust and customizable. Thank you nonetheless!