sawhney17 / logseq-automatic-linker

MIT License
94 stars 17 forks source link

every letter gets parsed? #62

Closed heemet closed 11 months ago

heemet commented 1 year ago

Hi; I reinstalled this plugin because it didn't like the shortcuts i assigned. But even if I don't touch the settings at all it parses every letter of my block. I don't know if this is operator error. attaching a screen recording.

https://github.com/sawhney17/logseq-automatic-linker/assets/15643869/93e16d02-5dd7-4a20-9656-da40fd2cc57c

davidefornelli commented 1 year ago

I have the same issue.

mruderman commented 1 year ago

Me too; this is on the Linux appimage of LogSeq version 0.9.15 Unfortunately, the plugin appears unusable.

DutchPete commented 1 year ago

I have the same issue.

My worry is that this plug-in has become abandonware because Aryen does not seem to respond anymore.

adxsoft commented 1 year ago

If you have an alias somewhere in your graph that only has a space as the alias name then every space is assumed to be a link.

alias:: x

where x is a SPACE!

The solution is find the 'bad' alias and either delete that line or put a actual alias name.

Blank space is NOT an alias name.

I will see if I can find the problem in the code .. it should ignore blank aliases.

DutchPete commented 1 year ago

I don't have aliases with spaces because properties cannot handle that, so if I want a multiword property I use hyphens, e.g. wordA-wordB.

adxsoft commented 1 year ago

An alias can have a space for it's value. Try it it gets accepted.

On Mon, 11 Sept 2023, 1:20 pm DutchPete, @.***> wrote:

I don't have aliases with spaces because properties cannot handle that, so if I want a multiword property I use hyphens, e.g. wordA-wordB.

— Reply to this email directly, view it on GitHub https://github.com/sawhney17/logseq-automatic-linker/issues/62#issuecomment-1713098353, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF5V4HPA5NXNNXI7FEKAI53XZZ7O3ANCNFSM6AAAAAA2DVA74E . You are receiving this because you commented.Message ID: @.***>

DutchPete commented 1 year ago

I don't want to try it because if I get used to it, sooner or later I will do it with another property too. Besides, it does bother me to use hyphens.

adxsoft commented 1 year ago

Ok, no problem.

On Mon, 11 Sept 2023, 1:27 pm DutchPete, @.***> wrote:

I don't want to try it because if I get used to it, sooner or later I will do it with another property too. Besides, it does bother me to use hyphens.

— Reply to this email directly, view it on GitHub https://github.com/sawhney17/logseq-automatic-linker/issues/62#issuecomment-1713102679, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF5V4HNCNEGVEPRB3Y2GFKDXZ2AI5ANCNFSM6AAAAAA2DVA74E . You are receiving this because you commented.Message ID: @.***>

adxsoft commented 1 year ago

Have submitted a Pull Request with the fix to resolve this issue

mruderman commented 12 months ago

@adxsoft, thanks for putting in the pull request.

Thank you @sawhney17 for developing this project, if you don't have time (totally understandable) for further maintenance of this extension, would you be OK if one of us officially forked it over, or would you be willing to open up admin rights for others (e.g., @adxsoft, myself, or others on this thread or in the broader community?

andreoliwa commented 11 months ago

Have submitted a Pull Request with the fix to resolve this issue

Maybe this issue can be closed.

DutchPete commented 11 months ago

@andreoliwa I think the issue should stay open until it is fixed.

andreoliwa commented 11 months ago

@DutchPete I understood that https://github.com/sawhney17/logseq-automatic-linker/pull/65 fixes this issue #62:

Have submitted a Pull Request with the fix to resolve this issue

The link to the PR is missing, but maybe @adxsoft can confirm/clarify.

DutchPete commented 11 months ago

@andreoliwa I installed the plug-in again and it works, so it is fixed therefore this issue can be closed, as you suggested. Thanks for your help.

andreoliwa commented 11 months ago

@heemet or @sawhney17 have the power to close the issue. 😅