search

sawhney17 / logseq-automatic-linker

MIT License
94 stars 17 forks source link

fix(logseq 10.5): Automatic link on pressing enter with Logseq 10.5 #77

Closed clarkissac closed 7 months ago

clarkissac commented 8 months ago

Problem

The automatic linking of pages didn't work. The Logseq team probably change the insertBlocks variable to insert-blocks. So the if condition stopped working.

Solution

change the comparison string

clarkissac commented 8 months ago

71

jotomo commented 8 months ago

Fix works for me (with 0.10.5) as well. Would also fix #64.

Lightup1 commented 8 months ago

Thanks a lot. How to easily install this version of the plugin?

borjarobert commented 8 months ago

Works for me too 🚀

markscamilleri commented 7 months ago

Should this be marked as a breaking change? I haven't tested it on a previous version (so the change might work with older versions). However, looking at the change, it looks like this won't be backwards compatible - and so users still on an older version of logseq will not be able to use the newest version of the plugin.

Otherwise, the condition can be amended to include both strings to make this fix backwards compatible

sawhney17 commented 7 months ago

this looks great, but I think that it would be useful to preserve backwards compatibility by adding an OR check for both of the conditions.