Fix `ITAB_DUPLICATE_KEY` and CamelCase

sbcgua / ajson

Yet another json parser serializer for ABAP

MIT License

50 stars 15 forks source link

Fix `ITAB_DUPLICATE_KEY` and CamelCase #100

Closed mbtools closed 2 years ago

mbtools commented 2 years ago

PR #96 was incomplete. It covered nested structures but not nested tables.

Test case set_tab_nested_struct fails with ITAB_DUPLICATE_KEY
Test case to_json_nested_table fails with incorrect JSON

Fix is to use <root>-name for the prefix for convert_struc and convert_table which is the correct value after mapping.

mbtools commented 2 years ago

I was found this when stringyfying zif_abapgit_definitions=>ty_files_tt. While trying to fix it, I broke other UTs, so I knew my solution wasn't correct until I got all green. 😄

sbcgua commented 2 years ago

Cool. Merging. :) Thanks for the fix.

P.S. just a side question, what do you think about #101 ? (I saw it in one of your commits)