search

sbcgua / ajson

Yet another json parser serializer for ABAP
MIT License
49 stars 15 forks source link

keep_item_order() vs create_from() #137

Closed larshp closed 1 year ago

larshp commented 1 year ago

calling create_from() with an existing ajson insance where keep_item_order() is set, returns a new instance where keep_item_order() is not set

I guess create_from() should inherit the keep_item_order from II_SOURCE_JSON?

https://github.com/sbcgua/ajson/blob/5e6278d185a90421ad8f28d4f0c79e00a771b063/src/zcl_ajson.clas.abap#L127-L150

sbcgua commented 1 year ago

Yes ... https://github.com/sbcgua/ajson/pull/117/files#diff-b145c7a1905ff4c3124f24af34209abae7721c6ae929b4482e17ab17d20698dcR173

Just need to find time to finish this PR ... or cherrypick the changes

larshp commented 1 year ago

@sbcgua did you have time to look into this?

sbcgua commented 1 year ago

Not yet. But I'll try to do it this week

larshp commented 1 year ago

no worries, first things first

sbcgua commented 1 year ago

117 merged, should work now. BTW note doc changes (deprecation notes at the beginning in particular)

sbcgua commented 1 year ago

Can be closed ?