Methods renames - Githubissues

sbcgua / ajson

Yet another json parser serializer for ABAP

MIT License

49 stars 15 forks source link

Methods renames #138

Open sbcgua opened 1 year ago

sbcgua commented 1 year ago

Maybe:

rename create_empty to new (in fact mirrors 7.40 new operator behavior and "compatible" with it)
rename create_from to from
... or even deprecate it in favor of clone/filter/map
... however, there is a subtle case, when cloning can be done from a "mirror" of ajson, an "inetgrated ajson copy". E.g. abapgit_ajson or whatever other project which included ajson (maybe http_agent with ajson ...). I this case a passive method from can "guess" the source and map it to native ajson types. Not sure if it is really needed.

mbtools commented 1 year ago

I prefer a "short verb" for method names as long as it's consistently used (i.e. not new for one class and create for another).

I don't mind adjusting existing code. Feel free to drop the old methods in a coming version 😄

sbcgua commented 1 year ago

I added new in #117. So it is there. create_empty will live for some time, we use it in our code base ... and actually in AG probably. By the way zcl_ajson is also create public now. So: zcl_ajson->new( ... ), create object zcl_ajson ... and 7.40 new zcl_ajson( ... ) do the same now (which is good :)

So, yeah, prefer those options and probably it makes sense to adjust AG code too. FYI @larshp

create vs new - yeah ... there are some conflicts, I confess. But new is better. :)