sbcgua / ajson

Yet another json parser serializer for ABAP
MIT License
49 stars 15 forks source link

"Compact" version of AJSON #146

Closed mbtools closed 1 year ago

mbtools commented 1 year ago

I have several projects where I want to include the core ajson functionality (no filter, no mapping). However, now it's all linked with dependencies, so I need to copy 3 classes + 4 interfaces + exception. Ideally, it should be 1 class, 1 interface, 1 exception.

I can, of course, clone and reduce this myself in another repo (with credit to you). But I wonder if there's a way to manage this in your repo without causing double maintenance. It needs an abapmerge for OO... Anyway, just something to think about.

sbcgua commented 1 year ago

I knew it would come one day ... I started feeling that ajson becomes a bit bloated.

First thoughts:

Just thoughts. No immediate solution.

sbcgua commented 1 year ago

any impact on existing projects if split the package into 3 subpackages (in one repo)? core, utils and perf (for perf test prog) ?

larshp commented 1 year ago

abapGit impact: might need some adjustments in the renaming, but no problem, go for it

larshp commented 1 year ago

anyhow, we will get tree-shaking sometime for ABAP, abaplint ftw

sbcgua commented 1 year ago

OK, so the first step would be this: #152 Have a look, if looks fine, I'll merge

mbtools commented 1 year ago

The split into core and others looks good. Thanks!