search

sbcgua / ajson

Yet another json parser serializer for ABAP
MIT License
49 stars 15 forks source link

Cloud compatibility #147

Closed mbtools closed 1 year ago

mbtools commented 1 year ago

I did a quick comparison with https://abapedia.org/ and most of the used standard classes and interfaces are released for ABAP Cloud. However, cl_abap_codepage is not released.

https://github.com/sbcgua/ajson/blob/b40ccfddb39a6124e6ec74d7d3e5202ba4c3ac9b/src/zcl_ajson.clas.locals_imp.abap#L259

Suggestion: replace with CL_ABAP_CONV_CODEPAGE.

larshp commented 1 year ago

no trivial task with code pages, got some snippets to convert to and from xstring, which works on prem and Steampunk,

https://github.com/open-abap/open-table-maintenance/blob/main/src/zcl_otm_table_maintenance.clas.abap#L360-L389

https://github.com/open-abap/open-table-maintenance/blob/main/src/zcl_otm_table_maintenance.clas.abap#L132-L161

sbcgua commented 1 year ago

Yeap, good suggestion. Will have a look

sbcgua commented 1 year ago

148