JSON_TO_ABAP: fix compressed JSON array to sorted/hashed table keeping components problem

sbcgua / ajson

Yet another json parser serializer for ABAP

MIT License

49 stars 15 forks source link

JSON_TO_ABAP: fix compressed JSON array to sorted/hashed table keeping components problem #182

Closed thorsten-wolf-neptune closed 2 weeks ago

thorsten-wolf-neptune commented 3 weeks ago

This PR reproduces the issue that is tracked https://github.com/sbcgua/ajson/issues/181 and contains a fix proposal.

larshp commented 3 weeks ago

perhaps move the CLEAR up to below code, to have less impact on performance

thorsten-wolf-neptune commented 3 weeks ago

tried that at first but that is outside of the loop of the array items so it wouldn't work https://github.com/sbcgua/ajson/pull/182/commits/3bbb2d7f4040f4fa9ff1961b96d787b71fb590d3#diff-018e6f26075d703b00b41a45a1c76360a17a8ce9846d7314b7b71c9a151f71b5R856

larshp commented 2 weeks ago

@sbcgua

thorsten-wolf-neptune commented 2 weeks ago

Thx :-) i only noticed it because in abapgit we have "skip initial fields" set to true for some TABU entries and when pulling it to a new system the tables where completely messed up :-)

@larshp once that is merged/fixed abapgit would need to also get the mirror updated or? Should i create an issue there too?

larshp commented 2 weeks ago

https://github.com/abapGit/abapGit/pull/6977