search

sbcgua / ajson

Yet another json parser serializer for ABAP
MIT License
53 stars 16 forks source link

unused variables #48

Closed larshp closed 3 years ago

larshp commented 3 years ago

found by abaplint rule unused_variables, which is currently disabled for this repo, I checked all 7 findings and it looks like its correct,

./src/zcl_ajson_mapping.clas.locals_imp.abap[68, 19]  - Variable "<token>" not used (unused_variables) [E]
./src/zcl_ajson_mapping.clas.locals_imp.abap[104, 19] - Variable "<token>" not used (unused_variables) [E]
./src/zcl_ajson.clas.abap[487, 10]                    - Variable "lt_path" not used (unused_variables) [E]
./src/zcl_ajson.clas.abap[491, 19]                    - Variable "<topnode>" not used (unused_variables) [E]
./src/zcl_ajson.clas.locals_imp.abap[757, 9]          - Variable "io_type" not used (unused_variables) [E]
./src/zcl_ajson.clas.testclasses.abap[1467, 16]       - Variable "gv_sample" not used (unused_variables) [E]
./src/zcl_ajson.clas.testclasses.abap[1906, 10]       - Variable "lo_nodes_exp" not used (unused_variables) [E]
sbcgua commented 3 years ago

unexpected :) let's remove them. Just check UTs are passing