search

sbcgua / ajson

Yet another json parser serializer for ABAP
MIT License
53 stars 16 forks source link

more basic unit tests #52

Closed larshp closed 3 years ago

larshp commented 3 years ago

Hi, the parse() test, https://github.com/sbcgua/ajson/blob/master/src/zcl_ajson.clas.testclasses.abap#L122 seems to be testing a lot?

Are you open to adding more basic unit tests before this? eg. one test method for each data type

sbcgua commented 3 years ago

generally yes, this is better. I'm just lazy to do one-by-one :) And I reuse that mock json a couple of times so it saves time. But conceptually this is better to have separate tests. Just one thing, this test tests types, and also depth. (Althought there is an integrational one somewhere there ...)

larshp commented 3 years ago

I'll just add more, more is more, more is better for unit tests

larshp commented 3 years ago

merged, closing