Something about daytimetable.json having a date key

sbhs-forkbombers / sbhs-timetable-node

Countdown and timetable all at once. 100% more JS, ∞% less PHP.

http://sbhstimetable.tk/

GNU Affero General Public License v3.0

2 stars 2 forks source link

Something about daytimetable.json having a date key #10

Closed quadrupleslap closed 10 years ago

quadrupleslap commented 10 years ago

I should really stop annoying you guys, shouldn't I? Anyway, if you haven't already, I think you could simplify a bit of your code now that the daytimetable.json dictionary has a date key in it. Close if you've already used it or don't care. :rabbit:

gnustomp commented 10 years ago

Yeah, uh, definitely could happen. Please have descriptive issue titles though.

Keyword: could

quadrupleslap commented 10 years ago

:P okay, okay. It's just you seem to have a lot of code in countdown.js that would appreciate this change. Especially the morbid-looking manualoverride variable.

fourkbomb commented 10 years ago

I'm guessing you mean removing all the code to work out if today is actually today, the day after, or the day after that, etc.

Short answer: Not going to happen.

Long answer: Essentially, that code is there so that if SBHS goes down (oh my that's never ever happened before), there'll still be some sort of countdown ability just as soon as I can be bothered to add default bells in. And if we ever add offline caching using HTML5 appcaches, it'll be useful then too.